Constraints serialization #148
Conversation
rozyczko
added
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
henrikjacobsenfys
left a comment
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
So this is essentially bringing back the unique ID's as far as I understand? If this is needed to make serialization work, then it looks good to me.
damskii9992
left a comment
damskii9992
left a comment
There was a problem hiding this comment.
Why do we need to be able to resolve dependencies specifically in an object hierarchy?
We can make all of this much simpler if we simply use the global map and always resolve all pending dependencies.
all_parameters = [param for param in global_map.vertices() if param isinstance DescriptorNumber && hasattr(param, '_pending_dependency_string')]For my remaining comments I made another PR with my suggested changes. It is mostly integrating your code further with the observer pattern and getting rid of the unique_name fallback as I don't see any use of that.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
hardcoded unique_name to serialization skip list
Details in the
PARAMETER_DEPENDENCY_SERIALIZATION.mdfile.The file is to be moved to the docs once they're actually present.